UT: Fix ECB TITLE to match current API value#179
Merged
jczaja merged 1 commit intoRustInFinance:mainfrom Mar 13, 2026
Merged
Conversation
Signed-off-by: Mateusz Bronk <mbronk@users.noreply.github.com>
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background / issue statement
The ECB Data Portal (remote API) changed the
TITLEattribute value for the USD/EUR series:which is breaking ❌
test_ecb_parse_exchange_rate_from_url.Changes
Updated test assertion as well as the offline
data/ecb_example_response.xmlto match current API.Note the
titlefield is unused in prod code, so no functional impact.etradeTaxReturnHelper/src/ecb.rs
Lines 88 to 89 in 7b34fa4